convertDeprecationsToExceptions during PHPunit tests #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1447 +/- ##
=========================================
Coverage 97.22% 97.22%
Complexity 2831 2831
=========================================
Files 175 175
Lines 9010 9010
=========================================
Hits 8760 8760
Misses 250 250 ☔ View full report in Codecov by Sentry. |
|
I was hoping that this would fail on PHP 8.2 because of the problems reported in issue #1445 But it passed - needs investigation. |
phil-davis
force-pushed
the
convertDeprecationsToExceptions
branch
from
407172b
to
bdd24fa
Compare
The deprecation things in recent PHP 8.* have been fixed in other PRs. But, IMO, we might as well have this extra setting in the unit tests. It may help us notice a deprecation in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phpunit.readthedocs.io/en/9.6/configuration.html#the-convertdeprecationstoexceptions-attribute