Add INodeByPath interface to allow optimizing getNodeForPath #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1060 +/- ##
=========================================
Coverage 97.32% 97.32%
- Complexity 2830 2833 +3
=========================================
Files 175 175
Lines 9419 9425 +6
=========================================
+ Hits 9167 9173 +6
Misses 252 252
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
I like the general idea. I dont know enough about this code parts, so dont expect I will merge it. Hopefully @evert or somebody else will have enough time to get this merged/reviewed |
DeepDiver1975
requested changes
Jun 4, 2018
|
Bump? |
|
I'm 4 years late but I do think this is a good idea :S |
|
@icewind1991 it has been a while ... 🙈 .... wana revive this with a rebase? THX |
icewind1991
force-pushed
the
node-by-path-interface
branch
from
111f2b3
to
7b20544
Compare
|
THX @icewind1991 |
|
Test are failing due to a change in the pgsql schema ..... |
fixed by #1509 |
icewind1991
force-pushed
the
node-by-path-interface
branch
from
4dfc955
to
ec160ce
Compare
icewind1991
force-pushed
the
node-by-path-interface
branch
2 times, most recently
from
118da1f
to
b1d4778
Compare
icewind1991
force-pushed
the
node-by-path-interface
branch
from
b1d4778
to
5e707d2
Compare
DeepDiver1975
approved these changes
Nov 9, 2023
This was referenced Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1059, doing this in a separate PR so the other can stay open for the "nested tree" discussion.
A few points of detail
INodeByPathdoes not extendICollectionsoTreecan implement the interface without further changes, havingTreeimplement this does not really provide any benefit atm though and was mostly done to support future tree nesting. It might be better to change it to extendICollectionand makeTreeimplement it if we ever make a collection.INodeByPath::getNodeForPathcan returnnull, I fear that requiring any collection implementing the interface to be able to retrieve all nodes within it's path would prevent the ability to cleanly allow nesting collections that implement the interface