Fix copyNode for case of file named 0 (#1030)

sabre-io · Jan 22, 2018 · 3e8249f · 3e8249f
1 parent 4acf420
commit 3e8249f
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/DAV/Tree.php b/lib/DAV/Tree.php
@@ -298,7 +298,9 @@ function getMultipleNodes($paths) {
      */
     protected function copyNode(INode $source, ICollection $destinationParent, $destinationName = null) {
 
-        if (!$destinationName) $destinationName = $source->getName();
+        if ((string)$destinationName === '') {
+            $destinationName = $source->getName();
+        }
 
         if ($source instanceof IFile) {
 

diff --git a/tests/Sabre/DAV/TreeTest.php b/tests/Sabre/DAV/TreeTest.php
@@ -24,6 +24,22 @@ function testCopy() {
 
     }
 
+    function testCopyFile() {
+
+        $tree = new TreeMock();
+        $tree->copy('hi/file', 'hi/newfile');
+
+        $this->assertArrayHasKey('newfile', $tree->getNodeForPath('hi')->newFiles);
+    }
+
+    function testCopyFile0() {
+
+        $tree = new TreeMock();
+        $tree->copy('hi/file', 'hi/0');
+
+        $this->assertArrayHasKey('0', $tree->getNodeForPath('hi')->newFiles);
+    }
+
     function testMove() {
 
         $tree = new TreeMock();