Skip to content

Commit

Permalink
fix(eslint-bod): drop eslint-plugin-flowtype support
Browse files Browse the repository at this point in the history
No need for `flowtype` eslint checking due to `@ts-check`.

issue #247.
PR #242.
  • Loading branch information
sabertazimi committed Oct 14, 2021
1 parent 507054b commit 4e2a2e4
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 27 deletions.
7 changes: 1 addition & 6 deletions packages/eslint-config-bod/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const restrictedGlobals = require('confusing-browser-globals');
module.exports = {
extends: [require.resolve('./base')],

plugins: ['import', 'flowtype', 'jsx-a11y', 'react-hooks'],
plugins: ['import', 'jsx-a11y', 'react-hooks'],

overrides: [
{
Expand Down Expand Up @@ -282,10 +282,5 @@ module.exports = {

// https://github.com/facebook/react/tree/main/packages/eslint-plugin-react-hooks
'react-hooks/rules-of-hooks': 'error',

// https://github.com/gajus/eslint-plugin-flowtype
'flowtype/define-flow-type': 'warn',
'flowtype/require-valid-file-annotation': 'warn',
'flowtype/use-flow-type': 'warn',
},
};
1 change: 0 additions & 1 deletion packages/eslint-config-bod/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"@typescript-eslint/parser": "^5.0.0",
"babel-preset-react-app": "^11.0.0-next.91",
"confusing-browser-globals": "^2.0.0-next.91",
"eslint-plugin-flowtype": "^6.1.0",
"eslint-plugin-import": "^2.25.1",
"eslint-plugin-jest": "^25.0.5",
"eslint-plugin-jsx-a11y": "^6.4.1",
Expand Down
20 changes: 0 additions & 20 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -9345,7 +9345,6 @@ __metadata:
"@typescript-eslint/parser": ^5.0.0
babel-preset-react-app: ^11.0.0-next.91
confusing-browser-globals: ^2.0.0-next.91
eslint-plugin-flowtype: ^6.1.0
eslint-plugin-import: ^2.25.1
eslint-plugin-jest: ^25.0.5
eslint-plugin-jsx-a11y: ^6.4.1
Expand Down Expand Up @@ -9435,18 +9434,6 @@ __metadata:
languageName: node
linkType: hard

"eslint-plugin-flowtype@npm:^6.1.0":
version: 6.1.0
resolution: "eslint-plugin-flowtype@npm:6.1.0"
dependencies:
lodash: ^4.17.21
string-natural-compare: ^3.0.1
peerDependencies:
eslint: ^7.32.0
checksum: a3c865273150d6d37243ec4c70e350bf52027df3c11c22af387b78ad3a45ede32eeeaa2b07d5545a7fab6f1e75321282be0337f9561000f25dc089587508abe4
languageName: node
linkType: hard

"eslint-plugin-html@npm:^6.2.0":
version: 6.2.0
resolution: "eslint-plugin-html@npm:6.2.0"
Expand Down Expand Up @@ -20342,13 +20329,6 @@ resolve@^2.0.0-next.3:
languageName: node
linkType: hard

"string-natural-compare@npm:^3.0.1":
version: 3.0.1
resolution: "string-natural-compare@npm:3.0.1"
checksum: 65910d9995074086e769a68728395effbba9b7186be5b4c16a7fad4f4ef50cae95ca16e3e9086e019cbb636ae8daac9c7b8fe91b5f21865c5c0f26e3c0725406
languageName: node
linkType: hard

"string-width@npm:^1.0.1":
version: 1.0.2
resolution: "string-width@npm:1.0.2"
Expand Down

0 comments on commit 4e2a2e4

Please sign in to comment.