Fixes for issue #2950 #3002
Open
Fixes for issue #2950 #3002
+500
−430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…now to clearly show progress
…e it for extra clarity alongside aria-valuenow
… explicit about their function -- cannot change name due to radio groups
…on't parse side content at all times, only when drawer is opened
…ocs updated to use them
…now to clearly show progress
…e it for extra clarity alongside aria-valuenow
… explicit about their function -- cannot change name due to radio groups
…on't parse side content at all times, only when drawer is opened
conflicts resolved
…ed in other docs
|
Do any of these need |
Good question. I think countdown and radial progress might need them! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please look over to ensure everything is fine! I did my own testing, but it's always better to have multiple pairs of eyes rather than just one. Be warned: It's a big pull!