Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add fontSize(text-2xs,text-xxs) #1181

Closed
wants to merge 1 commit into from
Closed

chore: add fontSize(text-2xs,text-xxs) #1181

wants to merge 1 commit into from

Conversation

kirklin
Copy link
Contributor

@kirklin kirklin commented Sep 26, 2022 •
edited

The XS in Tailwind has a size of 0.75 REM. Since 2XS is larger than XS, the value should be greater than 0.75 REM. Therefore, XXS is more appropriate.

https://tailwindcss.com/docs/font-size
#1069

@kirklin
chore: replace .text-2xs with text .text-xxs
81e0b2d 
The size of xs in tailwind is 0.75rem, while 2xs is larger than xs, so the value should be greater than 0.75rem. It is more appropriate to use xxs for naming
@saadeghi
Copy link
Owner

saadeghi commented Oct 5, 2022 •
edited

xs text size having the same name with Tailwinds's xs but with a different value is indeed a problem but I think the solution would be removing it and only use the size Tailwind already has. Adding another size like xxs etc. wouldn't fix anything.

I can't merge this PR. I just need to review every element using the xs size to make sure everything looks good with the other size, then I will delete the duplicate xs style.

@saadeghi saadeghi closed this Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kirklin @saadeghi