Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix border radius on mixed type buttons #1159

Merged
merged 2 commits into from Sep 21, 2022
Merged

Fix border radius on mixed type buttons #1159

merged 2 commits into from Sep 21, 2022

Commits on Sep 19, 2022

  1. Fix border radius on mixed type buttons 

    Currently, if you have buttons of different types (`a` vs `button` for example), the button styling breaks because the selectors depend on the button type:

Change to using child selectors as this doesn't care what type of child exists.
    @danawoodman
    danawoodman committed Sep 19, 2022
    Copy the full SHA
    ca11480 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2022

  1. bring back :not selectors for button 

    because otherwise, border radius of first and last children will be wrong
    @saadeghi
    saadeghi committed Sep 21, 2022
    Copy the full SHA
    d71af1c View commit details
    Browse the repository at this point in the history