[doc ]Fixed navbar unwanted scroll behavior #1008
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For example this link: Without With So I don't think removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #875.
Like stated in the issue, the
tabindexproblem has been fixed in the latest version of svelte-kit but attempting the upgrade introduced other issues, such as css selector changing specificities, breaking some global styles.When in comes to the unwanted scroll behavior, removing the
scroll-padding-topproperty from the layout seems to do the trick. Even after reading and testing how this property behaves (never used to before to be honest!), I don't see how it was impactful or what the intended behavior was. Let me know if this PR breaks anything.