Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git mv ./images/decrease_of_offen{c,s}e_codes.png #619

Merged
merged 1 commit into from May 14, 2022
Merged

git mv ./images/decrease_of_offen{c,s}e_codes.png #619

merged 1 commit into from May 14, 2022
+0 −0

Conversation

r7kamura
Copy link
Contributor

@r7kamura r7kamura commented May 14, 2022 •
edited

I found that an image link is broken in README.

This is due to the naming change from "offence" (british-style) to "offense" (american-style) at #614.
cc: @ydah

image

@r7kamura
Copy link
Contributor Author

r7kamura commented May 14, 2022 •
edited

I confirmed the problem will be fixed after this change.

https://github.com/ryz310/rubocop_challenger/blob/0766bdbcafa8cfbeb5d1d807e03a347806601790/README.md

image

@r7kamura r7kamura mentioned this pull request May 14, 2022
Open
ryz310
ryz310 approved these changes May 14, 2022
View reviewed changes
Copy link
Owner

@ryz310 ryz310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I appreciate your help!

@ryz310 ryz310 merged commit 0ba4303 into ryz310:master May 14, 2022
@r7kamura r7kamura deleted the feature/image-file-name branch May 14, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryz310 ryz310 ryz310 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r7kamura @ryz310