Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions #14

Merged
merged 3 commits into from Oct 14, 2022
Merged

Migrate to GitHub Actions #14

merged 3 commits into from Oct 14, 2022

Conversation

mattphelps-8451
Copy link
Collaborator

@mattphelps-8451 mattphelps-8451 commented Oct 13, 2022

WIP. Please provide feedback!

This PR should do the following:

  • Use GitHub Actions instead of Travis for building and publishing
  • Publish to Maven central (if we believe this will take long, we can limit this PR scope to just GHA)

Note: The warnings about set-output and save-state in the workflows will be resolved whenever this actions setup-java change gets released in 3.5.X or 3.6. actions/setup-java#390

"The expression ${artifactId} is deprecated. Please use ${project.artifactId} instead."
This warning occurs in modern versions of Maven. One line change.
@mattphelps-8451 mattphelps-8451 changed the title Gha Migrate to GitHub Actions and Publish to Maven Central Oct 13, 2022
@kylebrooks-8451 kylebrooks-8451 linked an issue Oct 14, 2022 that may be closed by this pull request
Copy link
Collaborator

@kylebrooks-8451 kylebrooks-8451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move to Apache Arrow before we publish to Maven central so that the Java package is in the proper organization. The GA part looks great, nice work!

@kylebrooks-8451 kylebrooks-8451 merged commit 63ccf90 into master Oct 14, 2022
@mattphelps-8451 mattphelps-8451 changed the title Migrate to GitHub Actions and Publish to Maven Central Migrate to GitHub Actions Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to Github Actions for CI/CD
2 participants