fix: Mark array_shift as having side effects

- fixes phpstan/phpstan#8084
ryium · Nov 10, 2022 · 37b4a74 · 37b4a74
1 parent 582a9cb
commit 37b4a74
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 0 deletions.
diff --git a/bin/functionMetadata_original.php b/bin/functionMetadata_original.php
@@ -36,6 +36,7 @@
 	'array_replace' => ['hasSideEffects' => false],
 	'array_replace_recursive' => ['hasSideEffects' => false],
 	'array_reverse' => ['hasSideEffects' => false],
+	'array_shift' => ['hasSideEffects' => true],
 	'array_slice' => ['hasSideEffects' => false],
 	'array_sum' => ['hasSideEffects' => false],
 	'array_udiff' => ['hasSideEffects' => false],

diff --git a/resources/functionMetadata.php b/resources/functionMetadata.php
@@ -702,6 +702,7 @@
 	'array_replace_recursive' => ['hasSideEffects' => false],
 	'array_reverse' => ['hasSideEffects' => false],
 	'array_search' => ['hasSideEffects' => false],
+	'array_shift' => ['hasSideEffects' => true],
 	'array_slice' => ['hasSideEffects' => false],
 	'array_sum' => ['hasSideEffects' => false],
 	'array_udiff' => ['hasSideEffects' => false],

diff --git a/tests/PHPStan/Analyser/NodeScopeResolverTest.php b/tests/PHPStan/Analyser/NodeScopeResolverTest.php
@@ -1127,6 +1127,7 @@ public function dataFileAsserts(): iterable
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/static-has-method.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/mixed-to-number.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/../Rules/Variables/data/bug-8113.php');
+		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-8084.php');
 	}
 
 	/**

diff --git a/tests/PHPStan/Analyser/data/bug-8084.php b/tests/PHPStan/Analyser/data/bug-8084.php
@@ -0,0 +1,16 @@
+<?php
+
+namespace Bug8084;
+
+use function array_shift;
+use function PHPStan\Testing\assertType;
+
+class Bug8084
+{
+	public function run(array $arr): void
+	{
+		/** @var array{a: 0, b?: 1} $arr */
+		assertType('0', array_shift($arr) ?? throw new \Exception());
+		assertType('1|null', array_shift($arr));
+	}
+}