test: skip broken FF nav test

rwoll · Jul 4, 2022 · d5cd654 · d5cd654
1 parent eb239a8
commit d5cd654
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/tests/async/test_har.py b/tests/async/test_har.py
@@ -20,7 +20,6 @@
 from pathlib import Path
 
 import pytest
-from flaky import flaky
 
 from playwright.async_api import Browser, BrowserContext, Error, Page, Route, expect
 from tests.server import Server
@@ -437,7 +436,9 @@ async def test_should_go_back_to_redirected_navigation(
     assert await page.evaluate("window.location.href") == "https://www.theverge.com/"
 
 
-@flaky(max_runs=5)  # Flaky upstream
+@pytest.mark.skip_browser(
+    "firefox"
+)  # skipped upstream (https://github.com/microsoft/playwright/blob/6a8d835145e2f4002ee00b67a80a1f70af956703/tests/library/browsercontext-har.spec.ts#L214)
 async def test_should_go_forward_to_redirected_navigation(
     context: BrowserContext, server: Server, assetdir: Path
 ) -> None:

diff --git a/tests/sync/test_har.py b/tests/sync/test_har.py
@@ -20,7 +20,6 @@
 from typing import Any, cast
 
 import pytest
-from flaky import flaky
 
 from playwright.sync_api import Browser, BrowserContext, Error, Page, Route, expect
 from tests.server import Server
@@ -374,7 +373,9 @@ def test_should_go_back_to_redirected_navigation(
     assert page.evaluate("window.location.href") == "https://www.theverge.com/"
 
 
-@flaky(max_runs=5)  # Flaky upstream
+@pytest.mark.skip_browser(
+    "firefox"
+)  # skipped upstream (https://github.com/microsoft/playwright/blob/6a8d835145e2f4002ee00b67a80a1f70af956703/tests/library/browsercontext-har.spec.ts#L214)
 def test_should_go_forward_to_redirected_navigation(
     context: BrowserContext, server: Server, assetdir: Path
 ) -> None: