This repository has been archived by the owner on Jan 12, 2020. It is now read-only.
going decorators stage-2 #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please double check, but I believe this is a duplicate of |
|
Yes it is ... and Jan is way more into decorators than me, so I can happily close this one here 😃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did update those
@trackeddecorators to stage-2, because my app withember-decorators@^3.1.0was complaining about those old ones.Of couse I broke the test-suite here. I need some assistance here, how to properly deal with stage-1 and stage-2 decorators at the same time. @pzuraq can you help? So I can turn these tests green?