Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use release-it version of project #313

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jelhan
Copy link
Contributor

@jelhan jelhan commented Feb 15, 2023

Using npx to run release-it has several trade-offs:

  1. release-it needs to be downloaded and installed first.
  2. It uses the latest version of release-it instead of the version installed in the project.

I think we should recommend using the version of release-it already installed in the project. The documentation already assumes that yarn is used as package manager. Following that assumption it would be yarn run release-it.

Additionally I fix the indentation of the code blocks to make them shown as being part of the item in the list.

@@ -49,9 +49,9 @@ yarn install

* And last (but not least 😁) do your release.

```sh
npx release-it
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, using npx release-it does exactly what you are asking (in this PR). If release-it is installed in the repo, it will use the local bin otherwise it will install it in a temp dir and use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants