Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated update-docs command to respect mixed file type extensions #121

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

jwlawrence
Copy link
Contributor

  • This is needed when working on transforms that require different i/o file types. Addresses update-docs command requires i/o to be matching filetypes #120
  • The regex is used to only process files with 'input.' or 'output.' in their filename. For some reason lookbehind groups are deemed invalid by eslint, which should be supported in these v
    ersions of node, but I wasn't able to get eslint to accept it. It would provide an additional layer of accuracy by ensuring a '.input.' pattern, but I feel confident that the lookahead is
    safe to use given the relatively structured nature of fixture filenames.

- This is needed when working on transforms that require different i/o file types
- The regex is used to only process files with 'input.' or 'output.' in their filename. For some reason lookbehind groups are deemed invalid by eslint, which should be supported in these v
ersions of node, but I wasn't able to get eslint to accept it. It would provide an additional layer of accuracy by ensuring a '.input.' pattern, but I feel confident that the lookahead is
safe to use given the relatively structured nature of fixture filenames.
@rwjblue rwjblue added the bug Something isn't working label Oct 29, 2020
@rwjblue rwjblue merged commit 0b9137a into rwjblue:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants