-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dependencies to use diesel 2.0.0-rc.0 and sqlx 0.6.0 #2242
Conversation
Okay I just tested it,
|
Now I get the following error when trying to use
The entire function looks like this
I'm not sure where to continue |
Okay I don't know what happened, I started a new project to reproduce the error but it didn't work, then I tried to build my main project and it also worked for some reason. If anybody wants to check it out I have a repo here: https://github.com/pintariching/docrab-api |
Were you able to get the example "databases" app working here? |
I get the example to work if I comment out the migrations. |
This will also fix an issue with the |
I figured out the migrations issue: pintariching#1 |
fix migrations in diesel_sqlite example code
Okay the examples now build and test without errors. I've also updated the todo example a bit. |
Hey! I just ran into a problem that this pull request will solve (the two different uuid versions, as mentioned above). Do you guys know when it could be merged ? |
How does the sqlx example even works ? The rocket_db_pools implementation of sqlx is still in 0.5. That's what i'm getting when using it in 0.6 (not on this example tho) apparently because the rocket types aren't up to date with the latest |
I think I updated the |
Any update on when this PR can be merged? There's a bugfix on |
I think SQLx and Diesel can now be updated to both 0.6.1 and 2.0.0 respectivley as they have both been updated by now |
Awesome, let's give this a whirl. Unfortunately UI tests are flaky, so we may get a failure. It's probably time to remove them, or somehow not depend on them, entirely. |
Merged in f0d678d with a few fixes. Thank you so much for this! Extraordinarily helpful. |
I have updated the dependency for
sqlx
from 0.5 to 0.6, but to do that,diesel
also needs to be updated to the latest release candidate as I get an issue about sqlx and diesel using different versions oflibsqlite-sys
The tests for
--contrib
all pass but some--example
test fail, they would probably have to be updated too.It might be better to wait for
diesel 2.0.0
to released fully but this works as a stopgap.As said in #2209, a feature flag should be also implemented but I think both
diesel
andsqlx
have to be updated at once