Merge pull request #57 from rvagg/rvagg/update

readable-stream@3

.travis.yml

@@ -1,10 +1,8 @@
 sudo: false
 language: node_js
 node_js:
-  - '4'
   - '6'
   - '8'
-  - '9'
   - '10'
 branches:
   only:

bl.js

@@ -1,7 +1,6 @@
 'use strict'
 var DuplexStream = require('readable-stream').Duplex
   , util         = require('util')
-  , Buffer       = require('safe-buffer').Buffer
 
 function BufferList (callback) {
   if (!(this instanceof BufferList))
@@ -259,10 +258,10 @@ BufferList.prototype.duplicate = function duplicate () {
 }
 
 
-BufferList.prototype.destroy = function destroy () {
+BufferList.prototype._destroy = function _destroy (err, cb) {
   this._bufs.length = 0
   this.length = 0
-  this.push(null)
+  cb(err)
 }
 
 

package.json

@@ -24,12 +24,11 @@
   ],
   "license": "MIT",
   "dependencies": {
-    "readable-stream": "^2.3.5",
-    "safe-buffer": "^5.1.1"
+    "readable-stream": "^3.0.1"
   },
   "devDependencies": {
     "faucet": "0.0.1",
     "hash_file": "~0.1.1",
-    "tape": "~4.9.0"
+    "tape": "~4.9.1"
   }
 }

test/test.js

@@ -683,6 +683,20 @@ tape('destroy no pipe', function (t) {
   t.equal(bl.length, 0)
 })
 
+tape('destroy with error', function (t) {
+  t.plan(3)
+
+  var bl = new BufferList('alsdkfja;lsdkfja;lsdk')
+  var err = new Error('kaboom')
+  bl.destroy(err)
+  bl.on('error', function (_err) {
+    t.equal(_err, err)
+  })
+
+  t.equal(bl._bufs.length, 0)
+  t.equal(bl.length, 0)
+})
+
 !process.browser && tape('destroy with pipe before read end', function (t) {
   t.plan(2)