-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update sentry-javascript monorepo to v8 (major) #1939
Conversation
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Here's the code health analysis summary for commits Analysis Summary
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@sentry/node@7.116.0, npm/@sentry/profiling-node@7.116.0, npm/@vitest/coverage-v8@1.6.0, npm/tsx@4.11.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This review largely involves package update. All the updates are upgrading the '@sentry/node' package from version 7.x to 8.0.0 in various sub-applications.
@@ -9,8 +9,8 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.114.0", | |||
"@sentry/profiling-node": "^7.114.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading version from 7.114.0 to 8.0.0 for sentry will bring several changes. Please ensure to read the update log and make changes to accommodate new breaking changes if required.
"@sentry/node": "^7.114.0", | ||
"@sentry/profiling-node": "^7.114.0", | ||
"@sentry/node": "^8.0.0", | ||
"@sentry/profiling-node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The '@sentry/profiling-node' version update would also need to reflect the changes made in '@sentry/node' to keep the errors and performance metric reporting in sync.
@@ -19,7 +19,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.114.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the connection package, the only change is the update of '@sentry/node'. Ensure this package is compatible with 'drizzle-orm' and 'vitest'.
@@ -19,7 +19,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.102.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version of '@sentry/node' in the database package is also updated. Double check the compatibility with '@types/pg', 'drizzle-orm' and 'pg'.
@@ -20,7 +20,7 @@ | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@fastify/sensible": "^5.5.0", | |||
"@sentry/node": "^7.102.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version of '@sentry/node' in the gateway package is updated. Review and validate its compatibility with the '@fastify/sensible' and 'fastify' to maintain error reporting integrity.
@@ -18,7 +18,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.102.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version of '@sentry/node' in the mcots package is updated. Ensure its compatibility with the 'rusty-motors-schema' and 'short-unique-id'.
@@ -19,7 +19,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.102.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the nps package, ensure the updated version of '@sentry/node' is compatible with the 'drizzle-orm' and 'short-unique-id' as these are the dependencies of this package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff shows that the '@sentry/node' and '@sentry/profiling-node' dependencies in the various package.json files have been upgraded from version 7 to 8. This in itself is not problematic, provided all dependencies are properly tested for compatibility with the upgraded version. We should ensure that these version upgrades do not introduce breaking changes or conflicts by thoroughly testing all functionalities dependent on these packages after the upgrade.
@@ -9,8 +9,8 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.114.0", | |||
"@sentry/profiling-node": "^7.114.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure that the new version ^8.0.0 of '@sentry/node' and '@sentry/profiling-node' in 'apps/main/package.json' do not contain breaking changes affecting our application. Consider running integration tests after these dependencies are upgraded.
@@ -19,7 +19,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.114.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify that the updated version ^8.0.0 of the '@sentry/node' dependency in 'packages/connection/package.json' works as expected within the functionalities of the connection package.
@@ -19,7 +19,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.102.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The '@sentry/node' version upgrade to ^8.0.0 in 'packages/database/package.json' should be tested thoroughly to avoid potential breakages in the database package's functionalities.
@@ -20,7 +20,7 @@ | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@fastify/sensible": "^5.5.0", | |||
"@sentry/node": "^7.102.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upgrade of '@sentry/node' to version ^8.0.0 in 'packages/gateway/package.json' may affect the gateway package, please validate its compatibility.
@@ -18,7 +18,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.102.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the version upgrade of '@sentry/node' to ^8.0.0 in 'packages/mcots/package.json' does not hinder any existing functionalities of the mcots package.
@@ -19,7 +19,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.102.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirm the upgraded ^8.0.0 version of '@sentry/node' in 'packages/nps/package.json' does not introduce breaking changes or instability to the nps package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update seems to primarily involve a version bump to the usage of @sentry/node
across several packages. It's good practice to keep dependencies up-to-date, so this is a positive change. However, please make sure to test the application thoroughly as major version changes sometimes come with breaking changes. This is critical for dependencies like @sentry/node
, which is a part of error tracking.
@@ -9,8 +9,8 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.114.0", | |||
"@sentry/profiling-node": "^7.114.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure @sentry/node version ^8.0.0 does not introduce unexpected changes as it's a major version upgrade.
"@sentry/node": "^7.114.0", | ||
"@sentry/profiling-node": "^7.114.0", | ||
"@sentry/node": "^8.0.0", | ||
"@sentry/profiling-node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just like in the previous package, ensure that the upgrade from @sentry/profiling-node
to version ^8.0.0 does not break existing functionalities.
@@ -19,7 +19,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.114.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the previous comments, make sure to test this package thoroughly with the upgraded @sentry/node
version. If it's feasible, consider adding automated regression tests to facilitate safer upgrades.
@@ -19,7 +19,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.102.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upgrade of @sentry/node
package to ^8.0.0 should be tested with interaction with other dependencies in this package, such as pg
and drizzle-orm
.
@@ -20,7 +20,7 @@ | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@fastify/sensible": "^5.5.0", | |||
"@sentry/node": "^7.102.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integration tests between @sentry/node
and fastify
may be needed here to ensure application stability due to this major version upgrade.
@@ -18,7 +18,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.102.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upgrade of version to ^8.0.0 needs close attention for regression issues, since error tracking is vital for production issue identification.
@@ -19,7 +19,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.102.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This major version upgrade from ^7.102.0 to ^8.0.0 needs careful regression testing. This upgrade could potentially affect the interaction with other dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code shows an upgrade in the version dependency for @sentry/node
across multiple packages. This is a significant version bump. It is essential to ensure the new version doesn't introduce breaking changes that could affect these packages. Testing these changes thoroughly is recommended.
@@ -9,8 +9,8 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.114.0", | |||
"@sentry/profiling-node": "^7.114.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @sentry/node
library has been updated to 8.0.0
. Ensure all the changes from the previous version (7.114.0
) have been noted and have been accounted for in the codebase.
"@sentry/node": "^7.114.0", | ||
"@sentry/profiling-node": "^7.114.0", | ||
"@sentry/node": "^8.0.0", | ||
"@sentry/profiling-node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @sentry/profiling-node
library has also been updated to 8.0.0
. Again, ensure any breaking changes, new features, or deprecated features are considered across the codebase.
@@ -19,7 +19,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.114.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sentry/node
library has been updated in connection
package as well. Check the package functionality thoroughly after the update.
@@ -19,7 +19,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.102.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sentry/node
library has been updated in database
package as well. Check the package functionality thoroughly after the update.
@@ -20,7 +20,7 @@ | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@fastify/sensible": "^5.5.0", | |||
"@sentry/node": "^7.102.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @sentry/node
library has been updated in gateway
package. Consider checking the associated crash reporting or error logging functionality related to Sentry changes in this package.
@@ -18,7 +18,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.102.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @sentry/node
library has been updated in mcots
package. Consider checking the associated crash reporting or error logging functionality related to Sentry changes in this package.
@@ -19,7 +19,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.102.0", | |||
"@sentry/node": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @sentry/node
library has been updated in nps
package. Consider checking the associated crash reporting or error logging functionality related to Sentry changes in this package.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1939 +/- ##
=====================================
Coverage 9.74% 9.74%
=====================================
Files 133 133
Lines 9730 9730
Branches 139 137 -2
=====================================
Hits 948 948
Misses 8782 8782
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
90e97da
to
7a24fcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodecovAI submitted a new review for 7a24fcf
@@ -19,7 +19,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.102.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sentry/node here was previously at version 7.102.0, before been updated to 8.0.0. Just note that depending on how Sentry is utilized in your codebase, updates could potentially cause issues. It is advisable that you test this thoroughly.
@@ -18,7 +18,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.102.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sentry/node package is also updated in this 'mcots' package from version 7.102.0 to 8.0.0. Ensure that this update doesn't break anything in this package.
@@ -19,7 +19,7 @@ | |||
"author": "", | |||
"license": "AGPL-3.0", | |||
"dependencies": { | |||
"@sentry/node": "^7.102.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, @sentry/node has been updated here from 7.102.0 to 8.0.0. Make sure that this doesn't introduce any regressions in the 'nps' package.
6e93246
to
19dbcd1
Compare
3d33fa8
to
2db47de
Compare
0fae9de
to
4d62248
Compare
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
4d62248
to
3cf6daf
Compare
Quality Gate passedIssues Measures |
This PR contains the following updates:
^7.102.0
->^8.0.0
^7.114.0
->^8.0.0
^7.114.0
->^8.0.0
Release Notes
getsentry/sentry-javascript (@sentry/node)
v8.0.0
Compare Source
Important Changes
The Bun SDK will now capture global unhandled errors.
Other Changes
http.client
spans if there is an active parent span (#11974)execArgv
are not sent to worker threads (#11963)Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.