Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split const integers into signed and unsigned #476

Merged
merged 1 commit into from Jul 15, 2018
Merged

split const integers into signed and unsigned #476

merged 1 commit into from Jul 15, 2018

Conversation

jrakow
Copy link
Contributor

@jrakow jrakow commented Jul 14, 2018

Integrate the changes in sgodwincs/webidl-rs#15

@jrakow
Copy link
Contributor Author

jrakow commented Jul 14, 2018

Conflicts with #460 which contains changes to the original const PR.
Ignore this until #460 is merged. I will then rebase or something.

alexcrichton
alexcrichton approved these changes Jul 14, 2018
View reviewed changes
Copy link
Contributor

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ohanar ohanar merged commit 0b78b34 into rustwasm:master Jul 15, 2018
@jrakow jrakow deleted the const-signed-unsiged branch July 15, 2018 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrakow @alexcrichton @ohanar