Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement on IntoWasmAbi and FromWasmAbi docs #3855

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

improvement on IntoWasmAbi and FromWasmAbi docs #3855

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a0505e
improvement on `IntoWasmAbi` and `FromWasmAbi` docs
alivarastepour Feb 25, 2024
b1c8daa
Update traits.rs
alivarastepour Feb 25, 2024
91c630b
removed extra space
alivarastepour Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/convert/traits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use crate::JsValue;
///
/// This is the opposite operation as `FromWasmAbi` and `Ref[Mut]FromWasmAbi`.
pub trait IntoWasmAbi: WasmDescribe {
/// The wasm ABI type that this converts into when crossing the ABI
/// The type which wasm ABI is provided when crossing the ABI
/// boundary.
type Abi: WasmAbi;

Expand All @@ -23,8 +23,8 @@ pub trait IntoWasmAbi: WasmDescribe {
///
/// This is the by-value variant of the opposite operation as `IntoWasmAbi`.
pub trait FromWasmAbi: WasmDescribe {
/// The wasm ABI type that this converts from when coming back out from the
/// ABI boundary.
/// The type which wasm ABI provides when coming back from ABI boundary,
/// to be converted to a rust type.
type Abi: WasmAbi;

/// Recover a `Self` from `Self::Abi`.
Expand Down