Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all instances of Self in methods #3631

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace all instances of Self in methods #3631

wants to merge 1 commit into from

Commits on Sep 23, 2023

  1. Replace all instances of Self in methods 

    Currently the `wasm_bindgen` macro only replaces top level occurrences
of the generic parameter `Self` in exported methods. This leads to an
error when returning parametrized types containing `Self` due to Rust
inner items rules.

This PR fixes the issue by drilling down the return type `TokenStream`
and replacing all instances of `Self` with the actual type name.

Signed-off-by: Oliver T <geronimooliver00@gmail.com>
    @snOm3ad
    snOm3ad committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    018061b View commit details
    Browse the repository at this point in the history