Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Fixed size array support #3458

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Conversation

stegaBOB
Copy link

@stegaBOB stegaBOB commented Jun 4, 2023

No description provided.

@daxpedda
Copy link
Collaborator

daxpedda commented Jun 4, 2023

Wow, that looks surprisingly less complicated then I imagined! Amazing work!

Keep in mind that I'm not entirely sure if or how this will conflict with #3454 in the future. But definitely willing to merge this, #3454 might be a long way off.

@stegaBOB
Copy link
Author

stegaBOB commented Jun 7, 2023

Thanks @daxpedda! The one thing that slightly concerns me is passing the array directly. Technically that wouldn't be FFI safe in C, but it seems to work at least for now. No guarantees that it continues to do so though. I messed around with trying to pass a single raw pointer back and forth (which might actually be more performant if we convert to JS TypedArrays). Might see if I can get that working. Would result in us not needing to make any changes to the xformer I think.

@daxpedda
Copy link
Collaborator

daxpedda commented Jun 7, 2023

I wouldn't feel comfortable enough reviewing something not FFI safe, so that's definitely preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants