Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo dependency resolver to v2 #3358

Merged
merged 1 commit into from
May 8, 2023

Conversation

daxpedda
Copy link
Collaborator

@daxpedda daxpedda commented Mar 16, 2023

This makes the wasm-bindgen project use resolver = "2", which already detected an issue in the CI, see #3358 (comment).

See the Cargo documentation for more info on this topic.

Fixes #3356.

@daxpedda
Copy link
Collaborator Author

I was surprised to see that wasm-bindgen actually still has std guards lying around, considering that no_std support was dropped a long time ago, see #2689.

I just removed the CI test for it, it wasn't actually testing it anyway, now that we use the new resolver it actually fails.
In a fit of insanity I had a brief attempt to actually fix the no_std built but turns out that it's not possible because some things actually rely on thread_local which isn't available in core or alloc.

@daxpedda daxpedda marked this pull request as ready for review March 16, 2023 23:21
@Liamolucko
Copy link
Collaborator

This seems reasonable, but it doesn't actually fix #3356. wit-validator is also a non-dev dependency of wasm-bindgen-cli-support, so this doesn't remove it from the dependency tree, plus rouille and walrus also have dependencies with future incompat warnings.

@daxpedda
Copy link
Collaborator Author

Hm, I think I was quite tired that night. Too bad, in any case upgrading the resolver is still a plus I guess.

@alexcrichton
Copy link
Contributor

Thanks and sorry for the delay!

@alexcrichton alexcrichton merged commit 8994cb9 into rustwasm:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

future incompat dependencies
3 participants