New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shell_test for wasm-audio-worklet example (build only) #3093

Merged

Liamolucko merged 1 commit into rustwasm:main from lukaslihotzki:test-wasm-audio-worklet

Sep 26, 2022

Contributor

lukaslihotzki commented Sep 26, 2022

Was part of #3069, but isn't helpful to actually test linked modules, because the shell tests are build-only.


          Add shell_test for wasm-audio-worklet example (build only)

d90696b

lukaslihotzki force-pushed the test-wasm-audio-worklet branch from 0616ecc to d90696b Compare

September 26, 2022 13:46

Liamolucko approved these changes

View reviewed changes

Collaborator

Liamolucko left a comment

The shell tests aren't build only; they also load the example and check that no errors are logged to the console.

But either way, this looks good to me 👍

Liamolucko merged commit ae5e4d7 into rustwasm:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment