web-sys: include VideoFrame in webgl texImage* functions #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jawadsh123
force-pushed
the
teximage2d-videoframe
branch
from
7b64984
to
78662e0
Compare
alexcrichton
approved these changes
Sep 12, 2022
bors bot
added a commit
to grovesNL/glow
that referenced
this pull request
Sep 20, 2022
227: [web] add tex_image_* fns for VideoFrame r=grovesNL a=jawadsh123 Hey 👋 texImage* bindings for VideoFrame were recently merged into web-sys (rustwasm/wasm-bindgen#3077) this PR allows using them on web through glow gated them behind `web_sys_unstable_apis`, since VideoFrame is [unstable in web-sys](https://rustwasm.github.io/wasm-bindgen/api/web_sys/struct.VideoFrame.html) Co-authored-by: Jawad Shaikh <shaikhjawad007@gmail.com>
bors bot
added a commit
to grovesNL/glow
that referenced
this pull request
Sep 20, 2022
227: [web] add tex_image_* fns for VideoFrame r=grovesNL a=jawadsh123 Hey 👋 texImage* bindings for VideoFrame were recently merged into web-sys (rustwasm/wasm-bindgen#3077) this PR allows using them on web through glow gated them behind `web_sys_unstable_apis`, since VideoFrame is [unstable in web-sys](https://rustwasm.github.io/wasm-bindgen/api/web_sys/struct.VideoFrame.html) Co-authored-by: Jawad Shaikh <shaikhjawad007@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VideoFrame is now a TexImageSource
updating webgl IDLs to reflect