Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] add tex_image_* fns for VideoFrame #227

Merged
merged 1 commit into from Sep 20, 2022
Merged

Conversation

jawadsh123
Copy link
Contributor

Hey 馃憢
texImage* bindings for VideoFrame were recently merged into web-sys (rustwasm/wasm-bindgen#3077)
this PR allows using them on web through glow

gated them behind web_sys_unstable_apis, since VideoFrame is unstable in web-sys

Copy link
Owner

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@grovesNL
Copy link
Owner

bors r+

bors bot added a commit that referenced this pull request Sep 20, 2022
227: [web] add tex_image_* fns for VideoFrame r=grovesNL a=jawadsh123

Hey 馃憢 
texImage* bindings for VideoFrame were recently merged into web-sys (rustwasm/wasm-bindgen#3077)
this PR allows using them on web through glow

gated them behind `web_sys_unstable_apis`, since VideoFrame is [unstable in web-sys](https://rustwasm.github.io/wasm-bindgen/api/web_sys/struct.VideoFrame.html)

Co-authored-by: Jawad Shaikh <shaikhjawad007@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 20, 2022

Build failed:

@grovesNL
Copy link
Owner

bors retry

@bors
Copy link
Contributor

bors bot commented Sep 20, 2022

@bors bors bot merged commit c8a011f into grovesNL:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants