Commits on Dec 6, 2020

1. ordered_float:NotNan may contain NaN after unwinding in assignment op… …

   …erators
   
   After using an assignment operators such as `NotNan::add_assign`,
   `NotNan::mul_assign`, etc., it was possible for the resulting `NotNan`
   value to contain a `NaN`.  This could cause undefined behavior in safe
   code, because the safe `NotNan::cmp` method contains internal unsafe
   code that assumes the value is never `NaN`.  (It could also cause
   undefined behavior in third-party unsafe code that makes the same
   assumption, as well as logic errors in safe code.)
   
   This was mitigated starting in version 0.4.0, by panicking if the
   assigned value is NaN.  However, in affected versions from 0.4.0 onward,
   code that continued after using unwinding to catch this panic could
   still observe the invalid value and trigger undefined behavior.
   
   The flaw is fully corrected in versions 1.1.1 and 2.0.1, by ensuring
   that the assignment operators panic without modifying the operand, if
   the result would be `NaN`.
   
   Fix details:
   
   reem/rust-ordered-float#20
   reem/rust-ordered-float#71

   

   mbrubeck committed Dec 6, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 1b49d49
   • Browse repository at this point

   Copy the full SHA

   1b49d49 View commit details

   Browse the repository at this point in the history