Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add smallvec unsoundness #337

Merged
merged 1 commit into from Jul 24, 2020
Merged

add smallvec unsoundness #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions crates/smallvec/RUSTSEC-0000-0000.toml
View file
Open in desktop
@@ -0,0 +1,18 @@
[advisory]
id = "RUSTSEC-0000-0000"
package = "smallvec"
date = "2018-09-25"
informational = "unsound"

title = "smallvec creates uninitialized value of any type"
url = "https://github.com/servo/rust-smallvec/issues/126"

description = """
Affected versions of this crate called `mem::uninitialized()` to create values of a user-supplied type `T`.
This is unsound e.g. if `T` is a reference type (which must be non-null and thus may not remain uninitialized).

The flaw was corrected by avoiding the use of `mem::uninitialized()`, using `MaybeUninit` instead.
"""

[versions]
patched = [">= 0.6.13"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right? The commit that closes the issue looks like it's only on 1.0 (was it backported)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it was backported: servo/rust-smallvec#180