New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undefined behavior in Rand #149
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d59af0f
Undefined behavior in rand_core
vks 3a9d04b
Undefined behavior in rand
vks 4f61057
Make Rand advisories informational
vks f4a382d
Don't mention violations of pointer provenance rules
vks 8125b66
Flaws -> flaw
vks 55fe596
rand_core: fix formatting
tarcieri 264c4a7
Fix TOML table formatting
tarcieri 128e7df
Fix versions TOML
tarcieri File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
[advisory] | ||
id = "RUSTSEC-0000-0000" | ||
package = "rand_core" | ||
date = "2019-04-19" | ||
informational = "unsound" | ||
title = "Unaligned memory access" | ||
description = """ | ||
Affected versions of this crate violated alignment when casting byte slices to | ||
integer slices, resulting in undefined behavior. | ||
|
||
The flaw was corrected by Ralf Jung and Diggory Hardy. | ||
""" | ||
patched_versions = [">= 0.4.2"] | ||
url = "https://github.com/rust-random/rand/blob/master/rand_core/CHANGELOG.md#050---2019-06-06" | ||
affected_functions = ["rand_core::BlockRng::next_u64", "rand_core::BlockRng::fill_bytes"] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look like the right toml format (maybe it changed); see https://github.com/RustSec/advisory-db#advisory-format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vks that is probably also the cause of the CI failure, though the message is quite cryptic: