Mention structopt advice under ansi_term
#1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pinkforest <36498018+pinkforest@users.noreply.github.com>
epage
approved these changes
Sep 2, 2022
TeXitoi
approved these changes
Sep 2, 2022
|
Technically, structopt is maintained. Just that breaking changes are out of scope as clap v3 is the breaking change of structopt. |
|
Cool, we'll just flag some on point advice related to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking structopt/clap2 specific actionable advice: clap-rs/clap#4172 under
ansi_termNot sure if this is feasible but see what others think 🤷♀️
As seen here:
I've asked @epage and @TeXitoi whether it would be also feasible to advice informational under
structoptto optionally move toclapv3 but it will be @TeXitoi's sole decision if they wish to do that - the crate should be still fine to use as-is I think though.