Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf 2.6.0 and 1.7.5 released with fix to RUSTSEC-2019-0003 #100

Merged
merged 1 commit into from May 19, 2019

Conversation

oherrala
Copy link
Contributor

@oherrala oherrala commented May 19, 2019

@oherrala oherrala changed the title protobuf 2.6.0 released with fix to RUSTSEC-2019-0003 protobuf 2.6.0 and 1.7.5 released with fix to RUSTSEC-2019-0003 May 19, 2019
@tarcieri tarcieri merged commit 39300b6 into rustsec:master May 19, 2019
@stepancheg
Copy link

I don't know what's the syntax of the file, but I suspect that definition

patched_versions = [">= 1.7.5, >= 2.6.0"] 

matches version 2.5.0 where this issue is not fixed.

From this example I think it should be

patched_versions = ["^1.7.5", ">= 2.6.0"] 

@oherrala oherrala deleted the rustsec-2019-0003 branch May 20, 2019 06:41
@oherrala
Copy link
Contributor Author

@stepancheg Seems to work with the current boundaries:

$ cargo update -p protoc-rust --precise 2.5.0
    Updating crates.io index
    Updating protobuf v2.6.0 -> v2.5.0
    Updating protobuf-codegen v2.6.0 -> v2.5.0
    Updating protoc v2.6.0 -> v2.5.0
    Updating protoc-rust v2.6.0 -> v2.5.0
$ cargo audit
    Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
      Loaded 24 security advisories (from /Users/oherrala/.cargo/advisory-db)
    Scanning Cargo.lock for vulnerabilities (322 crate dependencies)
error: Vulnerable crates found!

ID:      RUSTSEC-2019-0003
Crate:   protobuf
Version: 2.5.0
Date:    2019-06-08
URL:     https://github.com/stepancheg/rust-protobuf/issues/411
Title:   Out of Memory in stream::read_raw_bytes_into()
Solution: upgrade to: >= 1.7.5, >= 2.6.0

error: 1 vulnerability found!
$ cargo update 
    Updating crates.io index
    Updating protobuf v2.5.0 -> v2.6.0
    Updating protobuf-codegen v2.5.0 -> v2.6.0
    Updating protoc v2.5.0 -> v2.6.0
    Updating protoc-rust v2.5.0 -> v2.6.0
$ cargo audit
    Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
      Loaded 24 security advisories (from /Users/oherrala/.cargo/advisory-db)
    Scanning Cargo.lock for vulnerabilities (322 crate dependencies)
     Success No vulnerable packages found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants