This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Fix K8s API server connectivity for IPv6 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream library kube-rs uses an old way of connection to the K8s API, which in their implementation breaks on IPv6 clusters due to wrong URL formatting. This forces the lib to use the proper service, which works on IPv6 clusters as well.
|
@mKeRix Isn't this fixed in kube-rs/kube#597, if so the proper fix would be to upgrade the latest |
alex-berger
reviewed
Jan 18, 2022
(Note to myself) No, it is not fixed in upstream kube-rs , as kube-rs does not properly format IPv6 addresses in URL, it will create something like @mKeRix If you can address my comment above, I will happily merge this PR. |
There's no reason why this would need to be applied to IPv4 cluster, so instead it can simply be an optional setting with a note.
|
Indeed. Sorry, I should've made that clearer in my initial post. I have updated the pull request accordingly now. :) |
alex-berger
approved these changes
Jan 19, 2022
|
@mKeRix this PR is now part of today's |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream library kube-rs uses an old way of connection to the K8s API, which in their implementation breaks on IPv6 clusters due to wrong URL formatting. This forces the lib to use the proper service, which works on IPv6 clusters as well. The hint towards this solution is from kube-rs/kube#587 - the fix they implemented there is specific to using the rustls feature, which is not in use in this project. But the workaround works regardless.
I also made the env variables configure as a Helm value, in case somebody else needs to change something there in the future. Currently we've applied this fix with kustomize, but having it directly in the chart would let us get rid of that complexity. Plus, others can benefit as well. :)