Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SEC1-format EC keys via PKCS8 conversion #998

Merged
merged 2 commits into from Feb 6, 2022
Merged

Conversation

ctz
Copy link
Member

@ctz ctz commented Feb 6, 2022

This has been asked for 5-6 times over the past couple of years (including internally at my day job), so I think it's overdue for being supported. See, eg, #997, #332, #767, #245, #409 -- plus a number of downstream bugs.

While briansmith/ring#1456 (or equivalent) awaits merging, we'll achieve this in the meantime by chucking the PKCS8 outer layer around the SEC1 encoding.

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2022

Codecov Report

Merging #998 (fe64924) into main (f9a3d42) will increase coverage by 0.03%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #998      +/-   ##
==========================================
+ Coverage   96.25%   96.29%   +0.03%     
==========================================
  Files          60       60              
  Lines        9748     9785      +37     
==========================================
+ Hits         9383     9422      +39     
+ Misses        365      363       -2     
Impacted Files Coverage Δ
rustls/src/sign.rs 95.23% <97.36%> (+2.47%) ⬆️
rustls/src/x509.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a3d42...fe64924. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants