Catch conflicts with libc and stop generating them #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great find! This is going to help with the issues reported in #174, and give a bit of stability to our building suite. Gotta love those regressions in the latest nightly, I will push a fix to the Rust tree. |
|
Opened rust-lang/rust#124649 to fix the latest nightly issues. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, we can use a builtin lint to catch the scenario where we are accidentally re-generating a different type from
libc.When I tried it out using a little bit of
modand re-exporting, I found a number of cases where we were generating the same types, which might have led to some incompatibilities if we had e.g. layout mismatches from thelibctypes. This in combination with #181 should help us catch any weird differences between thelibcdefinitions andlibctruas well.