Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event_loop: remove deprecated run APIs #3683

Merged
merged 1 commit into from
May 20, 2024
Merged

event_loop: remove deprecated run APIs #3683

merged 1 commit into from
May 20, 2024

Conversation

kchibisov
Copy link
Member

@kchibisov kchibisov commented May 5, 2024 •
edited

The APIs are not well suited for the &dyn ApplicationHandler model and
Box<dyn EventLoop> structure, thus remove them.

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@kchibisov kchibisov force-pushed the kchibisov/remove-run branch 2 times, most recently from 3fe757d to fc20c52 Compare May 5, 2024 17:34
madsmtm
madsmtm approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍. Will follow-up with a PR to change the macOS and iOS backends to not need the shim any more.

notgull
notgull approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@kchibisov kchibisov force-pushed the kchibisov/remove-run branch 2 times, most recently from 94ddce1 to 37c754b Compare May 7, 2024 10:01
@kchibisov kchibisov mentioned this pull request May 10, 2024
Open
daxpedda
daxpedda approved these changes May 19, 2024
View reviewed changes
src/platform/web.rs Outdated Show resolved Hide resolved
@kchibisov
event_loop: remove deprecated run APIs
85a4c9a 
The APIs are not well suited for the `&dyn ApplicationHandler` model and
`Box<dyn EventLoop>` structure, thus remove them.
@kchibisov kchibisov merged commit 3e8fa41 into master May 20, 2024
52 checks passed
@kchibisov kchibisov deleted the kchibisov/remove-run branch May 20, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

@madsmtm madsmtm madsmtm approved these changes

@notgull notgull notgull approved these changes

@jackpot51 jackpot51 Awaiting requested review from jackpot51 jackpot51 is a code owner

@msiglreith msiglreith Awaiting requested review from msiglreith msiglreith is a code owner

@MarijnS95 MarijnS95 Awaiting requested review from MarijnS95 MarijnS95 is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kchibisov @daxpedda @madsmtm @notgull