Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rustc-check-cfg #3682

Merged
merged 1 commit into from
May 6, 2024
Merged

Enable rustc-check-cfg #3682

merged 1 commit into from
May 6, 2024

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented May 5, 2024

No description provided.

@madsmtm madsmtm added S - maintenance Repaying technical debt B - build failure labels May 5, 2024
@madsmtm madsmtm requested a review from kchibisov May 5, 2024 15:36
@madsmtm madsmtm mentioned this pull request May 5, 2024
5 tasks
build.rs Outdated Show resolved Hide resolved
@daxpedda
Copy link
Member

daxpedda commented May 5, 2024

Its just nightly for now, but when Cargo v1.80 releases we would need a permanent solution anyway. Couldn't we just always emit those instead of gating it behind an unstable feature or does this break anything?

@madsmtm
Copy link
Member Author

madsmtm commented May 5, 2024

Its just nightly for now, but when Cargo v1.80 releases we would need a permanent solution anyway. Couldn't we just always emit those instead of gating it behind an unstable feature or does this break anything?

Hmm, it produces a warning when using v1.70:

warning: cargo:rustc-check-cfg requires -Zcheck-cfg=output flag

I thought it would do more, but seems like the fix is actually just that simple.

@daxpedda
Copy link
Member

daxpedda commented May 5, 2024

@daxpedda
Copy link
Member

daxpedda commented May 5, 2024

I see you filed a bug as well: katharostech/cfg_aliases#7.

@madsmtm
Copy link
Member Author

madsmtm commented May 5, 2024

I see you filed a bug as well: katharostech/cfg_aliases#7.

Heh, oops

@madsmtm madsmtm requested a review from kchibisov May 5, 2024 21:55
@madsmtm madsmtm changed the title Enable rustc-check-cfg on nightly Enable rustc-check-cfg May 5, 2024
@madsmtm madsmtm requested a review from daxpedda May 5, 2024 21:59
@madsmtm madsmtm merged commit 16fd2ba into master May 6, 2024
52 checks passed
@madsmtm madsmtm deleted the madsmtm/fix-ci branch May 6, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants