Reduce usage of direct msg_send!
#3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
madsmtm/reduce-msg-send
branch
from
2cb9c8c
to
26ebbc1
Compare
kchibisov
approved these changes
May 6, 2024
kchibisov
force-pushed
the
madsmtm/reduce-msg-send
branch
from
26ebbc1
to
c472ad7
Compare
kchibisov
force-pushed
the
madsmtm/reduce-msg-send
branch
from
c472ad7
to
9596045
Compare
|
Thanks for merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msg_send!is more error-prone than using the generated bindings. Most of the methods that we're using now were not previously available inobjc2, but they are now, so let's use them!