Reexport older versions of raw-window-handle #3660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkmauve
force-pushed
the
reexport-more-rwh
branch
from
d96ce96
to
0562062
Compare
madsmtm
approved these changes
Apr 27, 2024
kchibisov
requested changes
May 3, 2024
| @@ -39,3 +39,7 @@ The migration guide could reference other migration examples in the current | |||
| changelog entry. | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### Fixed | |||
There was a problem hiding this comment.
Suggested change
| ### Fixed | |
| ### Added |
When the user decides to use an older version of raw-window-handle, through the rwh_04 or rwh_05 features, it makes sense to reexport the crate so they don’t have to depend on it manually and can instead use winit::raw_window_handle.
kchibisov
force-pushed
the
reexport-more-rwh
branch
from
0562062
to
d16e3b7
Compare
kchibisov
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user decides to use an older version of raw-window-handle, through the
rwh_04orrwh_05features, it makes sense to reexport the crate so they don’t have to depend on it manually and can instead usewinit::raw_window_handle.changelogmodule if knowledge of this change could be valuable to users