Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wayland: Add support for PinchGesture and RotationGesture #3656

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

wayland: Add support for PinchGesture and RotationGesture #3656

wants to merge 2 commits into from

Commits on Apr 27, 2024

  1. wayland: Add support for PinchGesture and RotationGesture 

    These two events are synthesized from the same event from the same
protocol, zwp_pointer_gestures_v1, and will always come together.

I’ve left over the third value, which is a dx/dy from the center of the
gesture, it could be exposed as a 2D scroll but I feel like this should
be a different event than the normal AxisMotion.

The documentation doesn’t indicate the unit of the rotation, so I’ve
left it as degrees.  I don’t have any Apple OS where I could test
whether that event is also in degrees or in radians there.

The other two gestures supported by this protocol, a multi-finger swipe,
and a multi-finger hold, aren’t currently matched with any event in
winit, would it make sense to expose them?

I’ve only tested on GNOME, but I expect other compositors to expose the
same protocol eventually.
    @linkmauve
    linkmauve committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    4e04741 View commit details
    Browse the repository at this point in the history

  2. wayland: Also synthesize PanGesture from a pinch 

    This new event is exactly what was missing for the previous commit.
    @linkmauve
    linkmauve committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    8815ac8 View commit details
    Browse the repository at this point in the history