Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winit version 0.30.0 #3655

Merged
merged 6 commits into from Apr 27, 2024
Merged

Winit version 0.30.0 #3655

merged 6 commits into from Apr 27, 2024

Conversation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a tad unfortunate that we loose git blame info on this file, but it's probably not used very often anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was kind of broken even before when I was moving changelog entries around.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it help if you did it in two commits, and then rebase merge the PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter how it's done, because it's moved anyway.

@linkmauve
Copy link
Contributor

Reading the changelog I wrote #3656, so that the new gestures support more than just two platforms. I’ve found that the unit of the rotation gesture isn’t specified, the Wayland protocol exposes it in degrees but I don’t know what Apple does, it would be useful to specify that before the release.

@kchibisov
Copy link
Member Author

The gestures are present for a very long time, like 2-3 years, it's just they were renamed a bit this release, so while specifying them is good, they were always meant for macOS only and the metrics are the same as in all other releases.

@linkmauve
Copy link
Contributor

Ah you’re right, they were already present in the previous release, but the unit is still unspecified in the documentation, so I still don’t know what it’s meant to be even on macOS. Or do you mean it’s a unit/event specific to macOS and shouldn’t be tried to be matched on other windowing systems?

Just in case, so the correct changelog will be rendered when pulling
the crate from the crates.io as archive and trying to build it.
growfrow and others added 2 commits April 27, 2024 15:29
Signed-off-by: growfrow <growfrow@outlook.com>
…3657)

Setting the background color changes how the window title bar appears,
which is something that the application should customize itself if it
wants this behaviour (and also, it wasn't set when calling
`set_transparent`, so the behaviour wasn't consistent).
@madsmtm
Copy link
Member

madsmtm commented Apr 27, 2024

The unit of rotation is documented in #3597 to be degrees.

- Allow all gestures simultaneously recognized.
- Add PanGestureRecogniser with min/max number of touches.
- Fix sending delta values relative to Update instead to match macOS.
- Fix rotation gesture units from iOS to be in degrees instead of radians.

Co-authored-by: Mads Marquart <mads@marquart.dk>
@kchibisov kchibisov marked this pull request as ready for review April 27, 2024 14:39
@kchibisov kchibisov merged commit 4b3c065 into v0.30.x Apr 27, 2024
52 checks passed
@kchibisov kchibisov deleted the kchibisov/rel-0300 branch April 27, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants