Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UIGestureRecognizerDelegate and PanGestureRecogniser plus default… #3597

Merged
merged 18 commits into from
Apr 27, 2024
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .cargo/config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ run-wasm = ["run", "--release", "--package", "run-wasm", "--"]
[build]
rustflags = ["--cfg=unreleased_changelogs"]
rustdocflags = ["--cfg=unreleased_changelogs"]

jpedrick marked this conversation as resolved.
Show resolved Hide resolved
9 changes: 9 additions & 0 deletions examples/window.rs
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ impl Application {
window.recognize_doubletap_gesture(true);
window.recognize_pinch_gesture(true);
window.recognize_rotation_gesture(true);
window.recognize_pan_gesture(true, 2, 2);
}

let window_state = WindowState::new(self, window)?;
Expand Down Expand Up @@ -414,6 +415,11 @@ impl ApplicationHandler<UserEvent> for Application {
println!("Rotated clockwise {delta:.5} (now: {rotated:.5})");
}
}
WindowEvent::PanGesture { delta, phase, .. } => {
window.panned.x += delta.x;
window.panned.y += delta.y;
println!("Panned ({delta:?})) (now: {:?}), {phase:?}", window.panned);
}
WindowEvent::DoubleTapGesture { .. } => {
println!("Smart zoom");
}
Expand Down Expand Up @@ -489,6 +495,8 @@ struct WindowState {
zoom: f64,
/// The amount of rotation of the window.
rotated: f32,
/// The amount of pan of the window.
panned: PhysicalPosition<f32>,

#[cfg(macos_platform)]
option_as_alt: OptionAsAlt,
Expand Down Expand Up @@ -532,6 +540,7 @@ impl WindowState {
modifiers: Default::default(),
occluded: Default::default(),
rotated: Default::default(),
panned: Default::default(),
zoom: Default::default(),
};

Expand Down
2 changes: 1 addition & 1 deletion src/changelog/unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
- **Breaking:** Renamed `platform::x11::XWindowType` to `platform::x11::WindowType`.
- Add the `OwnedDisplayHandle` type for allowing safe display handle usage outside of trivial cases.
- **Breaking:** Rename `TouchpadMagnify` to `PinchGesture`, `SmartMagnify` to `DoubleTapGesture` and `TouchpadRotate` to `RotationGesture` to represent the action rather than the intent.
- on iOS, add detection support for `PinchGesture`, `DoubleTapGesture` and `RotationGesture`.
- on iOS, add detection support for `PinchGesture`, `DoubleTapGesture`, `PanGesture` and `RotationGesture` as well as `UIGestureRecognizerDelegate` for fine grained control of gesture recognizers.
jpedrick marked this conversation as resolved.
Show resolved Hide resolved
- on Windows: add `with_system_backdrop`, `with_border_color`, `with_title_background_color`, `with_title_text_color` and `with_corner_preference`
- On Windows, Remove `WS_CAPTION`, `WS_BORDER` and `WS_EX_WINDOWEDGE` styles for child windows without decorations.
- **Breaking:** Removed `EventLoopError::AlreadyRunning`, which can't happen as it is already prevented by the type system.
Expand Down
20 changes: 20 additions & 0 deletions src/event.rs
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,19 @@ pub enum WindowEvent {
phase: TouchPhase,
},

/// N-finger pan gesture
///
/// ## Platform-specific
///
/// - Only available on **iOS**.
/// - On iOS, not recognized by default. It must be enabled when needed.
PanGesture {
device_id: DeviceId,
/// Change in pixels of pan gesture from last update.
delta: PhysicalPosition<f32>,
phase: TouchPhase,
},

/// Double tap gesture.
///
/// On a Mac, smart magnification is triggered by a double tap with two fingers
Expand Down Expand Up @@ -351,6 +364,7 @@ pub enum WindowEvent {
/// - On iOS, not recognized by default. It must be enabled when needed.
RotationGesture {
device_id: DeviceId,
/// change in rotation in degrees
delta: f32,
phase: TouchPhase,
},
Expand Down Expand Up @@ -1029,6 +1043,7 @@ impl PartialEq for InnerSizeWriter {

#[cfg(test)]
mod tests {
use crate::dpi::PhysicalPosition;
use crate::event;
use std::collections::{BTreeSet, HashSet};

Expand Down Expand Up @@ -1097,6 +1112,11 @@ mod tests {
delta: 0.0,
phase: event::TouchPhase::Started,
});
with_window_event(PanGesture {
device_id: did,
delta: PhysicalPosition::<f32>::new(0.0, 0.0),
phase: event::TouchPhase::Started,
});
with_window_event(TouchpadPressure {
device_id: did,
pressure: 0.0,
Expand Down
26 changes: 26 additions & 0 deletions src/platform/ios.rs
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,16 @@ pub trait WindowExtIOS {
/// The default is to not recognize gestures.
fn recognize_pinch_gesture(&self, should_recognize: bool);

/// Sets whether the [`Window`] should recognize pan gestures.
///
/// The default is to not recognize gestures.
fn recognize_pan_gesture(
jpedrick marked this conversation as resolved.
Show resolved Hide resolved
&self,
should_recognize: bool,
minimum_number_of_touches: u8,
maximum_number_of_touches: u8,
);

/// Sets whether the [`Window`] should recognize double tap gestures.
///
/// The default is to not recognize gestures.
Expand Down Expand Up @@ -212,6 +222,22 @@ impl WindowExtIOS for Window {
.maybe_queue_on_main(move |w| w.recognize_pinch_gesture(should_recognize));
}

#[inline]
fn recognize_pan_gesture(
&self,
should_recognize: bool,
minimum_number_of_touches: u8,
maximum_number_of_touches: u8,
) {
self.window.maybe_queue_on_main(move |w| {
w.recognize_pan_gesture(
should_recognize,
minimum_number_of_touches,
maximum_number_of_touches,
)
});
}

#[inline]
fn recognize_doubletap_gesture(&self, should_recognize: bool) {
self.window
Expand Down
71 changes: 64 additions & 7 deletions src/platform_impl/ios/uikit/gesture_recognizer.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
use icrate::Foundation::{CGFloat, NSInteger, NSObject, NSUInteger};
use super::UIView;
use icrate::Foundation::{CGFloat, CGPoint, NSInteger, NSObject, NSUInteger};
use objc2::{
encode::{Encode, Encoding},
extern_class, extern_methods, mutability, ClassType,
extern_class, extern_methods, extern_protocol, mutability,
rc::Id,
runtime::{NSObjectProtocol, ProtocolObject},
ClassType, ProtocolType,
};

// https://developer.apple.com/documentation/uikit/uigesturerecognizer
extern_class!(
/// (UIGestureRecognizer)[https://developer.apple.com/documentation/uikit/uigesturerecognizer]
#[derive(Debug, PartialEq, Eq, Hash)]
jpedrick marked this conversation as resolved.
Show resolved Hide resolved
pub(crate) struct UIGestureRecognizer;

Expand All @@ -19,14 +23,22 @@ extern_methods!(
unsafe impl UIGestureRecognizer {
#[method(state)]
pub fn state(&self) -> UIGestureRecognizerState;

/// (delegate)[https://developer.apple.com/documentation/uikit/uigesturerecognizer/1624207-delegate?language=objc]
/// @property(nullable, nonatomic, weak) id<UIGestureRecognizerDelegate> delegate;
#[method(setDelegate:)]
pub fn setDelegate(&self, delegate: &ProtocolObject<dyn UIGestureRecognizerDelegate>);

#[method_id(delegate)]
pub fn delegate(&self) -> Id<ProtocolObject<dyn UIGestureRecognizerDelegate>>;
}
);

unsafe impl Encode for UIGestureRecognizer {
const ENCODING: Encoding = Encoding::Object;
}

// https://developer.apple.com/documentation/uikit/uigesturerecognizer/state
// (UIGestureRecognizerState)[https://developer.apple.com/documentation/uikit/uigesturerecognizer/state]
#[repr(transparent)]
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub struct UIGestureRecognizerState(NSInteger);
Expand All @@ -45,7 +57,7 @@ impl UIGestureRecognizerState {
pub const Failed: Self = Self(5);
}

// https://developer.apple.com/documentation/uikit/uipinchgesturerecognizer
// (UIPinchGestureRecognizer)[https://developer.apple.com/documentation/uikit/uipinchgesturerecognizer]
extern_class!(
#[derive(Debug, PartialEq, Eq, Hash)]
pub(crate) struct UIPinchGestureRecognizer;
Expand All @@ -70,8 +82,8 @@ unsafe impl Encode for UIPinchGestureRecognizer {
const ENCODING: Encoding = Encoding::Object;
}

// https://developer.apple.com/documentation/uikit/uirotationgesturerecognizer
extern_class!(
/// (UIRotationGestureRecognizer)[https://developer.apple.com/documentation/uikit/uirotationgesturerecognizer]
#[derive(Debug, PartialEq, Eq, Hash)]
pub(crate) struct UIRotationGestureRecognizer;

Expand All @@ -95,8 +107,8 @@ unsafe impl Encode for UIRotationGestureRecognizer {
const ENCODING: Encoding = Encoding::Object;
}

// https://developer.apple.com/documentation/uikit/uitapgesturerecognizer
extern_class!(
/// (UITapGestureRecognizer)[https://developer.apple.com/documentation/uikit/uitapgesturerecognizer]
#[derive(Debug, PartialEq, Eq, Hash)]
pub(crate) struct UITapGestureRecognizer;

Expand All @@ -119,3 +131,48 @@ extern_methods!(
unsafe impl Encode for UITapGestureRecognizer {
const ENCODING: Encoding = Encoding::Object;
}

extern_class!(
/// (UIPanGestureRecognizer)[https://developer.apple.com/documentation/uikit/uipangesturerecognizer]
#[derive(Debug, PartialEq, Eq, Hash)]
pub(crate) struct UIPanGestureRecognizer;

unsafe impl ClassType for UIPanGestureRecognizer {
type Super = UIGestureRecognizer;
type Mutability = mutability::InteriorMutable;
}
);

extern_methods!(
unsafe impl UIPanGestureRecognizer {
#[method(translationInView:)]
pub fn translationInView(&self, view: &UIView) -> CGPoint;

#[method(setTranslation:inView:)]
pub fn setTranslationInView(&self, translation: CGPoint, view: &UIView);

#[method(velocityInView:)]
pub fn velocityInView(&self, view: &UIView) -> CGPoint;

#[method(setMinimumNumberOfTouches:)]
pub fn setMinimumNumberOfTouches(&self, minimum_number_of_touches: NSUInteger);

#[method(minimumNumberOfTouches)]
pub fn minimumNumberOfTouches(&self) -> NSUInteger;

#[method(setMaximumNumberOfTouches:)]
pub fn setMaximumNumberOfTouches(&self, maximum_number_of_touches: NSUInteger);

#[method(maximumNumberOfTouches)]
pub fn maximumNumberOfTouches(&self) -> NSUInteger;
}
);

extern_protocol!(
/// (@protocol UIGestureRecognizerDelegate)[https://developer.apple.com/documentation/uikit/uigesturerecognizerdelegate?language=objc]
pub(crate) unsafe trait UIGestureRecognizerDelegate: NSObjectProtocol {}

unsafe impl ProtocolType for dyn UIGestureRecognizerDelegate {
const NAME: &'static str = "UIGestureRecognizerDelegate";
}
);
5 changes: 3 additions & 2 deletions src/platform_impl/ios/uikit/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@ pub(crate) use self::device::{UIDevice, UIUserInterfaceIdiom};
pub(crate) use self::event::UIEvent;
pub(crate) use self::geometry::UIRectEdge;
pub(crate) use self::gesture_recognizer::{
UIGestureRecognizer, UIGestureRecognizerState, UIPinchGestureRecognizer,
UIRotationGestureRecognizer, UITapGestureRecognizer,
UIGestureRecognizer, UIGestureRecognizerDelegate, UIGestureRecognizerState,
UIPanGestureRecognizer, UIPinchGestureRecognizer, UIRotationGestureRecognizer,
UITapGestureRecognizer,
};
pub(crate) use self::responder::UIResponder;
pub(crate) use self::screen::{UIScreen, UIScreenOverscanCompensation};
Expand Down