Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes unnecessary initial resize on Windows #3581

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes unnecessary initial resize on Windows #3581

wants to merge 3 commits into from

Conversation

aedm
Copy link

@aedm aedm commented Mar 12, 2024 •
edited

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

On Windows, this code calculates the size of the window before creating it instead of using CW_USEDEFAULT.

Tested using WindowBuilder::new().with_inner_size() with both PhysicalSize and LogicalSize on multiple scale factors.

Fixes only the Windows-related part of #2094. (It doesn't fix Wayland.)

@aedm aedm requested a review from msiglreith as a code owner March 12, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msiglreith msiglreith Awaiting requested review from msiglreith msiglreith is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
DS - windows
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aedm @daxpedda