Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor main example #3542

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Refactor main example #3542

wants to merge 6 commits into from
+429 −500

Commits on Mar 1, 2024

  1. Move monitor functionality out of the main window example

    @madsmtm
    madsmtm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    7248204 View commit details
    Browse the repository at this point in the history

  2. Remove a level of indirection in main window example 

    We already have the `Action` enum that abstracts key and mouse event bindings; on top of that, putting each action handler in its own functions seems excessive.
    @madsmtm
    madsmtm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    1edf4f1 View commit details
    Browse the repository at this point in the history

  3. Remove option_as_alt example state

    @madsmtm
    madsmtm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    1bef238 View commit details
    Browse the repository at this point in the history

  4. Remove Display impl for Action

    @madsmtm
    madsmtm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    c6dfe62 View commit details
    Browse the repository at this point in the history

  5. Inline example helper functionality 

    It is more clear what's happening when you don't have to jump to the bottom of the file to look at the implementation.
    @madsmtm
    madsmtm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    21fecf2 View commit details
    Browse the repository at this point in the history

  6. Rename window example to full, to signify that it's a large example

    @madsmtm
    madsmtm committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    926fb05 View commit details
    Browse the repository at this point in the history