Add more specific error RequestIgnored
#3481
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
S - api
madsmtm
commented
Feb 9, 2024
| /// | ||
| /// See [`InnerSizeWriter::request_inner_size`] for details. | ||
| #[derive(Debug, Clone)] // Explicitly not other traits, in case we want to extend it in the future | ||
| pub struct RequestIgnored { |
There was a problem hiding this comment.
@kchibisov asked in #3067 (comment):
What's the reason this error is here and not on the
windowfor example?
Because it's specific to InnerSizeWriter, which is also in this module.
madsmtm
force-pushed
the
request-ignored
branch
from
ae94840
to
2443baa
Compare
daxpedda
approved these changes
Feb 10, 2024
madsmtm
force-pushed
the
request-ignored
branch
from
2443baa
to
ac0f918
Compare
kchibisov
requested changes
Feb 23, 2024
There was a problem hiding this comment.
It's not really specific to this particular situation, sometimes it happens on X11 when setting something, e.g. locking.
In general we should have something like
error WindowError {
NotSupported,
RequestIgnored,
// etc...
}
We can leave it for 0.31, given that the a lot of weird hack like this one will be gone and it'll be more clear what to put into errors, once folks look into what their backends can do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #3067.
CHANGELOG.mdif knowledge of this change could be valuable to users