Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly implement Debug for Window and WindowBuilder #3297

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented Dec 24, 2023

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@madsmtm madsmtm added the S - maintenance Repaying technical debt label Dec 24, 2023
@daxpedda
Copy link
Member

This actually highlights a couple of problems we currently have:

  • The reason why we put SendSyncWrapper on Fullscreen inside of WindowAttributes is because on MacOS it doesn't implement Sync, maybe we should (can we?) fix that. Because at least right now it's exposed as sync even when it shouldn't.
  • SendSyncWrapper should actually not implement Debug, because this means the inner type, which isn't actually Send + Sync might get accessed on the wrong thread, e.g. as in WindowAttributes. Same with Clone.
  • RawWindowHandle (in WindowBuilder::with_parent()) is fine because it's unsafe anyway.

@daxpedda
Copy link
Member

Addressed this in #3303.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S - maintenance Repaying technical debt
Development

Successfully merging this pull request may close these issues.

None yet

2 participants