Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IME event support for Wayland #2154

Conversation

kchibisov
Copy link
Member

No description provided.

@kchibisov kchibisov force-pushed the new-wayland-composition-event branch 2 times, most recently from b4b7173 to e84ba2f Compare January 18, 2022 01:04
@kchibisov
Copy link
Member Author

If someone is interested in testing it in client the support is implemented in alacritty/alacritty#5790

Copy link

@rano-oss rano-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you bump wayland-rs (protocols/client) to 29.4? There is a use after free bug that has been fixed there. It might make the text gibberish.
Except for that it looks great!

@kchibisov
Copy link
Member Author

Could you bump wayland-rs (protocols/client) to 29.4? There is a use after free bug that has been fixed there. It might make the text gibberish.
Except for that it looks great!

Usually you don't need that, since downstream can do that. Though we could force the usage of 0.29.4 in winit I guess.(alacritty is already using it for example).

@kchibisov kchibisov force-pushed the new-wayland-composition-event branch from e84ba2f to b959e2a Compare January 21, 2022 05:00
@kchibisov kchibisov merged commit 5042d9a into rust-windowing:composition-event Jan 21, 2022
@kchibisov kchibisov deleted the new-wayland-composition-event branch January 21, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants