Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transparent window crash on Windows 11 #2121

Merged
merged 3 commits into from Jan 3, 2022
Merged

Fix transparent window crash on Windows 11 #2121

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
305e725
Fix transparent window crash on Windows 11
yslib Jan 1, 2022
bd56620
Update CHANGELOG.md
yslib Jan 3, 2022
9f81b4e
Merge branch 'master' into master
msiglreith Jan 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
39 changes: 23 additions & 16 deletions src/platform_impl/windows/window.rs
View file
Open in desktop
Expand Up @@ -16,6 +16,7 @@ use winapi::{
shared::{
minwindef::{HINSTANCE, LPARAM, UINT, WPARAM},
windef::{HWND, POINT, POINTS, RECT},
winerror::SUCCEEDED,
},
um::{
combaseapi, dwmapi,
Expand Down Expand Up @@ -699,22 +700,6 @@ impl<'a, T: 'static> InitData<'a, T> {
let dpi = hwnd_dpi(window);
let scale_factor = dpi_to_scale_factor(dpi);

// making the window transparent
if self.attributes.transparent && !self.pl_attribs.no_redirection_bitmap {
// Empty region for the blur effect, so the window is fully transparent
let region = CreateRectRgn(0, 0, -1, -1);

let bb = dwmapi::DWM_BLURBEHIND {
dwFlags: dwmapi::DWM_BB_ENABLE | dwmapi::DWM_BB_BLURREGION,
fEnable: 1,
hRgnBlur: region,
fTransitionOnMaximized: 0,
};

dwmapi::DwmEnableBlurBehindWindow(window, &bb);
DeleteObject(region as _);
}

// If the system theme is dark, we need to set the window theme now
// before we update the window flags (and possibly show the
// window for the first time).
Expand Down Expand Up @@ -809,6 +794,28 @@ impl<'a, T: 'static> InitData<'a, T> {

pub unsafe fn on_create(&mut self) {
let win = self.window.as_mut().expect("failed window creation");

// making the window transparent
if self.attributes.transparent && !self.pl_attribs.no_redirection_bitmap {
// Empty region for the blur effect, so the window is fully transparent
let region = CreateRectRgn(0, 0, -1, -1);

let bb = dwmapi::DWM_BLURBEHIND {
dwFlags: dwmapi::DWM_BB_ENABLE | dwmapi::DWM_BB_BLURREGION,
fEnable: 1,
hRgnBlur: region,
fTransitionOnMaximized: 0,
};
let hr = dwmapi::DwmEnableBlurBehindWindow(win.hwnd(), &bb);
if !SUCCEEDED(hr) {
warn!(
"Setting transparent window is failed. HRESULT Code: 0x{:X}",
hr
);
}
DeleteObject(region as _);
}

let attributes = self.attributes.clone();

// Set visible before setting the size to ensure the
Expand Down