Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Adapt new KeyboardEvent on IME event interface #2091

Closed

Conversation

komi1230
Copy link
Contributor

@komi1230 komi1230 commented Dec 8, 2021

This is related to #1497 and #1979.
I made is_synthetic field in KeyboardEvent filled with OS's IME status.

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@ArturKovacs
Copy link
Contributor

Could you explain why this change is useful?

@komi1230
Copy link
Contributor Author

I have misunderstood this is_synthetic field in KeyboardInput means the state of IME.
But the meaning of this field looks more generic event for winit.

I'm closing this PR.

@komi1230 komi1230 closed this Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants