Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.26.0 #2043

Merged
merged 1 commit into from Dec 1, 2021
Merged

Release 0.26.0 #2043

merged 1 commit into from Dec 1, 2021

Conversation

Copy link
Contributor

@ArturKovacs ArturKovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving for macos even though I'm not a maintainer anymore (but there isn't a macos maintainer right now)

@maroider
Copy link
Member

The only potentially blocking issue I could find was #1995.

@tinaun
Copy link
Contributor

tinaun commented Nov 1, 2021

would love to get #2046 in 0.26 if possible, been bothering me for ages

@filnet
Copy link
Contributor

filnet commented Nov 1, 2021

I think #2007 could make it into a release.

@msiglreith
Copy link
Member

@maroider Thanks for the reminder! Opened a PR to bump the version #2047

@parasyte
Copy link

parasyte commented Nov 2, 2021

Nominating #2027 as a blocking issue.

@maroider
Copy link
Member

maroider commented Nov 2, 2021

I'm hesitant to block on #2046 and #2027 since we don't have a maintainer for macOS ATM.

@sourcebox
Copy link

#2027 is currently a blocker for all mac apps that uses dialogs and requires either workarounds or using a fork. So merging this PR can only make the situation better. BTW: emilk as the creator of egui is an experienced developer, so there's a good chance it will not break anything.

@francesca64
Copy link
Member

@sourcebox I'll be reviewing (and merging) both #2027 and #2046.

@msiglreith
Copy link
Member

Nominating #2060 as this appears to be a regression from 0.25

@kchibisov kchibisov marked this pull request as ready for review November 20, 2021 00:42
@kchibisov
Copy link
Member Author

Since all linked issues were fixed, we can cut a new release.

@maroider
Copy link
Member

Can we squeeze in #1957 and #2025?

@kchibisov
Copy link
Member Author

I'm not sure about #1957, since it's unclear when the things move. As for the last one I can't say much, depends on web maintainers.

@adrien-ben
Copy link
Contributor

I don't know if it's too late but ndk-glue 0.5 was just released. I opened #2071.

@madsmtm
Copy link
Member

madsmtm commented Nov 24, 2021

Let's not block on anything further than #1957 and #2025, and for these at a maximum like three or four days.

Anything that makes it in this time-frame goes, everything else will have to wait.

Copy link
Member

@maroider maroider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been six days now, so I say we push the release through within the next 24 hours or so. #2025 can be included in a patch release.

CHANGELOG.md Outdated
@@ -1,4 +1,4 @@
# Unreleased
# 0.26.0 (2021-10-31)
Copy link
Member

@madsmtm madsmtm Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update this date before the actual release

@kchibisov kchibisov merged commit ea1c031 into rust-windowing:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet