Skip to content

Commit

Permalink
macOS: Move util::EMPTY_RANGE to usage spot (#3685)
Browse files Browse the repository at this point in the history
  • Loading branch information
madsmtm committed May 6, 2024
1 parent 0a3cacd commit cb39ab2
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
3 changes: 0 additions & 3 deletions src/platform_impl/macos/util.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
use objc2_foundation::{NSNotFound, NSRange, NSUInteger};
use tracing::trace;

pub static EMPTY_RANGE: NSRange = NSRange { location: NSNotFound as NSUInteger, length: 0 };

macro_rules! trace_scope {
($s:literal) => {
let _crate = $crate::platform_impl::platform::util::TraceGuard::new(module_path!(), $s);
Expand Down
12 changes: 7 additions & 5 deletions src/platform_impl/macos/view.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ use objc2_app_kit::{
};
use objc2_foundation::{
MainThreadMarker, NSArray, NSAttributedString, NSAttributedStringKey, NSCopying,
NSMutableAttributedString, NSObject, NSObjectProtocol, NSPoint, NSRange, NSRect, NSSize,
NSString, NSUInteger,
NSMutableAttributedString, NSNotFound, NSObject, NSObjectProtocol, NSPoint, NSRange, NSRect,
NSSize, NSString, NSUInteger,
};

use super::app_delegate::ApplicationDelegate;
Expand All @@ -25,7 +25,7 @@ use super::event::{
scancode_to_physicalkey,
};
use super::window::WinitWindow;
use super::{util, DEVICE_ID};
use super::DEVICE_ID;
use crate::dpi::{LogicalPosition, LogicalSize};
use crate::event::{
DeviceEvent, ElementState, Ime, Modifiers, MouseButton, MouseScrollDelta, TouchPhase,
Expand Down Expand Up @@ -259,14 +259,16 @@ declare_class!(
if length > 0 {
NSRange::new(0, length)
} else {
util::EMPTY_RANGE
// Documented to return `{NSNotFound, 0}` if there is no marked range.
NSRange::new(NSNotFound as NSUInteger, 0)
}
}

#[method(selectedRange)]
fn selected_range(&self) -> NSRange {
trace_scope!("selectedRange");
util::EMPTY_RANGE
// Documented to return `{NSNotFound, 0}` if there is no selection.
NSRange::new(NSNotFound as NSUInteger, 0)
}

#[method(setMarkedText:selectedRange:replacementRange:)]
Expand Down

0 comments on commit cb39ab2

Please sign in to comment.